-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload failed, but says "total success" #50
Comments
Interesting, can you please zip and attach here the contents of |
I think I know why it happened. Jiotty remembers upload tokens for files you previously tried to upload, not to re-upload them again. However, when you log out and log in as another google user, those upload tokens are no longer valid. In fact, the whole upload state needs to be invalidated on logout. I’ll fix this. |
@wheleph just in case you’d still want to contribute this one is quite simple. A css change to make links look more like links (underline) and also remove more files on logout (it already removes credentials, just need to also delete data.json). |
Actually, It’s a bit more involved, sorry. I’ve started working on it today. |
Archive.zip |
Thanks. Can you quit the app, delete data.json and then launch the app and try again? If it works this time, then this confirms why I think it fails. It should also fix the problem for you. |
OK I deleted the app and emptied the ~/.jiotty... folder New log files |
Looks like this time you hit an existing limitation where you are trying to re-upload a photo that's been uploaded manually, or via a different app. It was actually previously possible to do it, but I made it worse later, see #49 |
…; make links underlined; fix resume option not appearing for the very first time
@axylee can I please ask you to translate the following line in all Chinese resources, like before? Please leave %s placeholder - it will display the value of "progressBoxFailuresHyperlinkText" resource, for example, 错误: |
Alright thanks for the explanation, I think I understand. From a novice user POV perhaps the type of thing you could say here could be "X photos skipped which already existed in Google Photos". In my opinion that wouldn't be a failure or error as such, but a notification or info type message. I checked that photo URL and it says Uploaded by Android. I must admit I was a bit lost trying to understand the choices you were discussing relating to either re-uploading existing photos or preserving album image order! |
@
Unfortunately, it's impossible to devise what the cause of this error is. All I get from Google Photos is the generic "INVALID_ARGUMENT" error, so assuming this error means exactly what you said above may confuse a user, if the actual cause is different.
In order to understand this, you need to read through issue #49. In short, with current Google Photos API, Jiotty can either
but not both (1) and (2). Currently, Jiotty is on setting (2). Issue #49 will allow the user to decide. |
OK I did a test, I edited the 3 images on my machine and cropped them so that they are visually different from the ones already uploaded. I ran the upload again and it didn't show any errors this time. Latest from the log:
|
Sorry that's some pretty terrible formatting, don't know why that happened. |
Right, renamed all the photos and they all uploaded and the albums appeared 👍 - so it just needs unique filenames? what happens if you've got dupe filenames in your collection? eg things like DSC0001.jpg etc? |
The reason Jiotty did not even attempt to upload them again was because you left the "resume from last attempt" checkbox on when trying again. It rightly did not attempt to upload the files that it already uploaded. It doesn't know you edited them. Although possible, I don't think I'll be supporting the file change detection yet.
They will all be uploaded. There is no requirement for all file names to be unique. |
Sure , I am travel this few days , I will finished it by this week . So I just edit the files in "code " , to create a new branch , then pull request ? |
@axylee yes, sounds right. Thanks for your help! |
Fixed in 1.3.0 |
This one is pending Dutch translations, but will close as these depend on voluntary work by others and are not guaranteed. |
Firstly. thanks for this, seems like it could be incredibly useful!
Unfortunately I can't get it to work on a small set of test images...
The text was updated successfully, but these errors were encountered: