Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose on a maven repo #26

Open
razyalov opened this issue Aug 29, 2016 · 3 comments
Open

Expose on a maven repo #26

razyalov opened this issue Aug 29, 2016 · 3 comments

Comments

@razyalov
Copy link

Any reason this great project is not available on any of the public maven repositories as a ready to import artifact?

@ymartineau
Copy link
Owner

peers-js relies on a jar from oracle jdk based on JAVA_HOME environment variable: ${java.home}/lib/plugin.jar.

I'm not sure it's compatible as is with maven central repo dependencies availability:
"we do strongly encourage making sure all your dependencies are included in Central"

I'm not sure this one is available on maven repo.

Considering the latest trends (java blocked by default in firefox), etc. I should probably comment out peers-js in parent pom to avoid issues (hoping it's enough). I still want to keep it in repository, I think it helps some people. But for me it's okay if it's not built by default.

I'll think about it.

@paraplexed
Copy link
Contributor

peers-js definitely was useful for us when we first starting to use the peers framework.

Adding this repo to maven central would also make our lives a lot easier. Also it's the main thing keeping us from open sourcing our call testing framework using peers as a back end (since it requires someone building peers locally before being able to use ours, we feel it's not ready to be open sourced).

I'd be happy to help anywhere I can to get this project onto Maven Central.

@razyalov
Copy link
Author

razyalov commented Sep 6, 2016

I'm actually only using the core peers lib not the JS plug in.
If the core could be exposed as a maven dependency that would be great.
The java audio soundmanager would be nice as well but the core library is what I care about the most

Raz

On Sep 6, 2016, at 2:54 PM, Derek Clifford notifications@github.com wrote:

peers-js definitely was useful for us when we first starting to use the peers framework.

Adding this repo to maven central would also make our lives a lot easier. Also it's the main thing keeping us from open sourcing our call testing framework using peers as a back end (since it requires someone building peers locally before being able to use ours, we feel it's not ready to be open sourced).

I'd be happy to help anywhere I can to get this project onto Maven Central.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants