-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM-1003] Add Elevation
type
#37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… For e.g. test target access it buy just importing YCoreUI and not @testaable import YCoreUI
karthikyml
requested review from
mpospese,
sanjibchakraborty,
devyml and
SahilSainiYML
December 15, 2022 07:25
Closed
@karthikyml This all looked really good but I made several adjustments once I started playing with it:
|
mpospese
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Design specifies shadows differently than we do in code on iOS. They often refer to them as “elevations”.
Purpose
Elevation
struct encapsulates data as per shadows in design softwareSingle operation:
func apply(layer: CAlayer, cornerRadius: CGFloat)
Sets shadow properties such as
shadowOpacity
,shadowColor
,shadowOffset
,shadowRadius
But
shadowPath
is only set in the case whenuseShadowPath
is true. (Default istrue
)Discussion
Because the implementation of
spread
requires ashadowPath
, we will not be able to implement a shadow with a spread for a view whose shape we do not know. For example, shapes that are not rect or round rect.Out of Scope
We might need to tweak the proposed spread algorithm i.e. add spread to corner radius as well.
📈 Coverage
Code