Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-51] Log warnings when fallback image is delivered. #52

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Issue-51] Log warnings when fallback image is delivered. #52

merged 1 commit into from
Mar 17, 2023

Conversation

mpospese
Copy link
Contributor

Introduction

When either ImageAsset or SystemImage fails to load an image and delivers the fallback image instead we should log a warning to the console to alert the developer.

Purpose

Fix #51: Optionally log warning to console when delivering the fallback image.

Scope

  • Add logging to ImageAsset.image
  • Add logging to SystemImage.image
  • Add a logger singleton plus a flag to optionally silence it.
  • Unit tests

📈 Coverage

Code

100%
image

Documentation

100%
image

@mpospese mpospese added the enhancement New feature or request label Mar 16, 2023
@mpospese mpospese self-assigned this Mar 16, 2023
@mpospese mpospese linked an issue Mar 16, 2023 that may be closed by this pull request
Log warnings in ImageAsset.image and SystemImage.image when loadImage() fails #51
Closed
@mpospese mpospese merged commit 06398c4 into main Mar 17, 2023
@mpospese mpospese deleted the issue/51-log-warnings-on-image-fallback branch March 17, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyml devyml devyml approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners

@sanjibchakraborty sanjibchakraborty Awaiting requested review from sanjibchakraborty

@karthikyml karthikyml Awaiting requested review from karthikyml

@SahilSainiYML SahilSainiYML Awaiting requested review from SahilSainiYML

Assignees

@mpospese mpospese

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log warnings in ImageAsset.image and SystemImage.image when loadImage() fails
2 participants
@mpospese @devyml