[Issue-46] Clamp sRGB display values #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We format RGB values as hex without considering that with extended sRGB, channel values might be less than 0x00 or greater than 0xFF. We should restrict the values to this range but provide a warning.
Purpose
Fix #46 Make sure displayed hex channel values are between 0x00 and 0xFF
Scope
UIColor.rgbDisplayValue()
Discussion
When a value falls outside of the range, we will clamp it to 0x00-0xFF and log a console warning (unless logging has been disabled). This adopts a similar logging mechanism to what we use when
ImageAsset
orSystemImage
fails to load an image and must resort to the fallback.For the newly added⚠️ " emoji to the output string for colors that fall outside of the sRGB color space.
rgbDebugDisplayValue()
method we will also append a "📱 Screenshots
📈 Coverage
Code
100%
Documentation
100%