Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RapaNui improvement: put on layer #91

Closed
MattiaFortunati opened this issue Nov 21, 2012 · 6 comments
Closed

RapaNui improvement: put on layer #91

MattiaFortunati opened this issue Nov 21, 2012 · 6 comments

Comments

@MattiaFortunati
Copy link
Collaborator

Image creation should be split from adding/removing props on screen. So users can have more power for complex projects. And things like clearing the screen will be possible.

ex:
local image= RNFactory.createImage("image",{putOnLayer=false})--putOnLayer param is to keep old projects safe (image default behaviour won't change)

or

local image= RNFactory.createImage("image",layer,{params})--if layer is not specified default RNFactory.screen is taken

or (keeping old methods and adding )

local image=RNFactory.loadImage("image",{params})

also

RNFactory.putOnLayer(image,layer) --when we'll have multilayer feature.

@vertti
Copy link
Contributor

vertti commented Nov 21, 2012

I'd rather call it with a new method like RNFactory.loadImage and leave the createImage intact than have magic extra params added every time to a method call that radically change it's behavior.

@niom
Copy link
Contributor

niom commented Nov 21, 2012

or even better if you could pass the layer to the RNFactory.createImage("image", layer) instead of the magical parameter flag. If the additional parameter is missing you can use the default layer.

@MattiaFortunati
Copy link
Collaborator Author

Thanks guys, you are right, i'll update issue with your suggestions.

@niom
Copy link
Contributor

niom commented Nov 25, 2012

This issue should be merged with with issue #59, since they very similar and tied together.

@MattiaFortunati
Copy link
Collaborator Author

Sure, issue, closed, let's continue on #59

@MattiaFortunati
Copy link
Collaborator Author

Allright,
this will close the issue:
5a4896c

^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants