Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blender: Fix missing Grease Pencils in review #5848

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Blender: Fix missing Grease Pencils in review #5848

merged 1 commit into from
Nov 2, 2023
+3 −2

Conversation

simonebarbieri
Copy link
Member

Changelog Description

Fix Grease Pencil missing in review when isolating objects.

Additional info

When isolating objects for review, the grease pencils objects were excluded. This was supposed to be solved in #5812, but it was missing the case of isolating objects.

Testing notes:

  1. Try creating a review and add an object that include grease pencil to the instance (they must be linked to the review instance collection).
  2. Publish the review. The Grease Pencil should be visible.

@simonebarbieri simonebarbieri added type: bug Something isn't working sponsored Client endorsed or requested host: Blender labels Nov 1, 2023
@simonebarbieri simonebarbieri self-assigned this Nov 1, 2023
@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Nov 1, 2023
LiborBatek
LiborBatek approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been tested both in legacy OP and also in Ayon mode and all working normally.

image

Grease Pencil being always present in the Review.

@LiborBatek LiborBatek merged commit ef7a3fc into develop Nov 2, 2023
11 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 2, 2023
@mkolar mkolar deleted the bugfix/blender-missing-greasepencil-review branch January 25, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@simonebarbieri simonebarbieri

Labels
host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.17.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonebarbieri @LiborBatek @ynbot