Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Include Grease Pencil in review and thumbnails #5812

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Blender: Include Grease Pencil in review and thumbnails #5812

merged 2 commits into from
Oct 24, 2023

Conversation

simonebarbieri
Copy link
Contributor

Changelog Description

Include Grease Pencil in review and thumbnails.

Testing notes:

  1. Publish a model that includes Grease Pencil and a Review.
  2. Check that the review and the thumbnails include the grease pencil.

@simonebarbieri simonebarbieri added type: bug Something isn't working sponsored Client endorsed or requested host: Blender labels Oct 24, 2023
@simonebarbieri simonebarbieri self-assigned this Oct 24, 2023
@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

7 similar comments
@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot
Copy link
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7163 Blender: thumbnail extractor

@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Oct 24, 2023
@simonebarbieri @BigRoy
Use set instead of list to check types
bd545bc 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
BigRoy
BigRoy approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it - but code changes look good to me.

LiborBatek
LiborBatek approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Review contains the Grease Pencil assets too. So working as expected.
image

@simonebarbieri simonebarbieri merged commit c3d6ce0 into develop Oct 24, 2023
5 checks passed
@simonebarbieri simonebarbieri deleted the bugfix/OP-7163_blender_thumbnail_extractor branch October 24, 2023 10:46
@ynbot ynbot added this to the next-patch milestone Oct 24, 2023
@simonebarbieri simonebarbieri mentioned this pull request Nov 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

@BigRoy BigRoy BigRoy approved these changes

Assignees

@simonebarbieri simonebarbieri

Labels
host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@simonebarbieri @ynbot @BigRoy @LiborBatek