Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Publishing renders from Maya fails #43

Closed
2 tasks done
antirotor opened this issue Feb 28, 2024 · 3 comments
Closed
2 tasks done

Bug: Publishing renders from Maya fails #43

antirotor opened this issue Feb 28, 2024 · 3 comments
Assignees

Comments

@antirotor
Copy link
Member

antirotor commented Feb 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

Creating simple rendering instance and publishing will result in Collect Inputs crashing (see log below).

This stems from Maya classic - naming of render layers: rs_Main vs. Main.

Expected Behavior:

Collector shouldn't crash and it should use the correct name. These lines are expecting rs_ prefixed layer name:

https://github.com/ynput/ayon-core/blob/73568637348ed92310bbff7cfc90121cb396e4fc/client/ayon_core/hosts/maya/plugins/publish/collect_inputs.py#L183-L185

But it is getting it from here:

https://github.com/ynput/ayon-core/blob/73568637348ed92310bbff7cfc90121cb396e4fc/client/ayon_core/hosts/maya/plugins/publish/collect_render.py#L255

and it is now producing not prefixed name.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Run Maya 2024
  2. Create render instance (I've didn't created any render layers beforhand, just relied on default Main)
  3. Publish

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

File "C:\Users\annat\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402271655_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-core\client\ayon_core\hosts\maya\plugins\publish\collect_inputs.py", line 131, in process
    containers = self._collect_renderlayer_inputs(scene_containers,
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-core\client\ayon_core\hosts\maya\plugins\publish\collect_inputs.py", line 184, in _collect_renderlayer_inputs
    query=True,
RuntimeError: 'Main' is not a render layer.

Additional context:

This happended during testing of ynput/ayon-core#113 but I don't think it is related

[cuID:AY-2541]

@tokejepsen
Copy link
Member

I can confirm that the merge of ynput/ayon-core#113 introduced this bug. Had a successful running tests before this merge. After the merge this bug is introduced to the publishing.

@antirotor
Copy link
Member Author

I can confirm that the merge of ynput/ayon-core#113 introduced this bug. Had a successful running tests before this merge. After the merge this bug is introduced to the publishing.

I was digging into the code and couldn't find exact point where it is broken by that PR. Fix should be easy, but to not to introduce some side effects, it would be nice to find it.

@iLLiCiTiT iLLiCiTiT transferred this issue from ynput/ayon-core Jul 29, 2024
@BigRoy BigRoy self-assigned this Sep 17, 2024
@antirotor
Copy link
Member Author

I guess this is no longer the case, rendering from maya works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants