Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Build development workflow for plugin and monorepo. #27

Closed
atimmer opened this issue Mar 12, 2019 · 0 comments
Closed

Build development workflow for plugin and monorepo. #27

atimmer opened this issue Mar 12, 2019 · 0 comments
Assignees
Labels
8 Story points Meta Issue for team Meta
Milestone

Comments

@atimmer
Copy link
Contributor

atimmer commented Mar 12, 2019

Summary

In the monorepo setup we can longer set yoastseo/yoast-components to a GitHub URL in the package.json. This is problematic for trunk development. Locally, developers can use yarn link to develop, but that doesn't work for Travis or for building a zip.

Explanation

The plugin needs a command which does:

  • Clone the monorepo, or fetch the latest version if that is currently not the case.
    • It should fetch the same branch as is currently checked out, with one exception: trunk should checkout develop in the monorepo.
  • Run yarn link-all inside the monorepo.
  • Run yarn link [package] for every package inside the Yoast SEO package.json that is scoped using @yoast.

Technical decisions

The command should also run on Travis.

@atimmer atimmer added this to the JavaScript monorepo milestone Mar 12, 2019
@bintzandt bintzandt added 8 Story points Meta Issue for team Meta labels Mar 12, 2019
@bintzandt bintzandt self-assigned this Mar 19, 2019
@bintzandt bintzandt changed the title Build development workflow voor plugin en de monorepo. Build development workflow for plugin and monorepo. Mar 19, 2019
@bintzandt bintzandt removed their assignment Mar 20, 2019
@andizer andizer self-assigned this Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
8 Story points Meta Issue for team Meta
Projects
None yet
Development

No branches or pull requests

5 participants