Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts-plugin to diagnostic sources #103

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Add ts-plugin to diagnostic sources #103

merged 4 commits into from
Apr 7, 2024

Conversation

yoavbls
Copy link
Owner

@yoavbls yoavbls commented Apr 7, 2024

In the new official extension of Vue VSCode plugin, Hybrid mode is enabled by default,
which means that a TypeScript LSP Plugin publishes the diagnostics.
We didn't have ts-plugin in our diagnostic sources list so I add it.
and it solved #100 #101

@rchl
Copy link

rchl commented Apr 8, 2024

Is ts-plugin the identifier of the vue ts plugin? Shouldn't it have more specific naming? Otherwise it could conflict with other extensions (not sure what the implications of that be).
@johnsoncodehk

@yoavbls
Copy link
Owner Author

yoavbls commented Apr 8, 2024

@rchl I think ts-plugin is the identifier Volar or other TypeScript LSP Plugins use.
The plugin kicks in only for js/ts based files so I don't think it could conflict and work in improper places, but maybe @johnsoncodehk can clarify this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants