Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is getting blocked #3

Closed
bhaskarmishra opened this issue Dec 2, 2019 · 6 comments · Fixed by #4
Closed

App is getting blocked #3

bhaskarmishra opened this issue Dec 2, 2019 · 6 comments · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@bhaskarmishra
Copy link

bhaskarmishra commented Dec 2, 2019

App loading gets blocked if there is some issue with the pendo url/connectivity. I see there is no error handling. In order to replicate, just block the pendo url using dev tools and the app just hangs. Ideally, it should allow app to load even if there is an issue with pendo.

@EricTendian
Copy link
Contributor

I've found that Pendo is blocked by quite a few adblockers, I had to disable adblock on the page I was using it on for it to load.

@bhaskarmishra
Copy link
Author

That's correct @EricTendian, Any blocking of Pendo should not stop the app from loading.

@yociduo
Copy link
Owner

yociduo commented Dec 4, 2019

I will handle on this

@yociduo yociduo self-assigned this Dec 4, 2019
@yociduo yociduo added the bug Something isn't working label Dec 4, 2019
@bhaskarmishra
Copy link
Author

Thanks @yociduo, will wait for the release.

@yociduo
Copy link
Owner

yociduo commented Dec 11, 2019

@bhaskarmishra @EricTendian Bump a new version for v1.2.2.
I still want to use RxJS to solve this problem. Pendo script still needs 5 ~ 10 seconds to load in China, which means there will be a long initialization time. This change is in progress and will be released in the next major release
https://github.com/yociduo/ngx-pendo/compare/rxjs

@bhaskarmishra
Copy link
Author

Thanks @yociduo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants