Adding script error handler to prevent Angular initialization process getting stuck #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some ad blockers, it is possible for the Pendo script to be blocked. Right now, as this is hooking into the
APP_INITIALIZERfor Angular, the promise must resolve or be rejected before the rest of the app loads.If the script fails to load, then the
onerrorfunction will be triggered, rejecting the promise, and allowing the rest of the app to load. This does not handle the issue of a very slow internet connection (where the app is hanging until the script can finish downloading), but it's a start.This will fix #3 - it is the solution I'm using now to deal with the issue (as my site can have users with adblock).