Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application breaks if the app cannot obtain the pendo JS file #5

Closed
doronsever opened this issue Dec 25, 2019 · 3 comments
Closed

Application breaks if the app cannot obtain the pendo JS file #5

doronsever opened this issue Dec 25, 2019 · 3 comments

Comments

@doronsever
Copy link
Contributor

If for some reason the application cannot obtain the js file (for instance something wrong in nginx or someone blocked it) the whole application breaks.
This shouldn't happen.
To fix this, all you need to do is not to reject the promise in

ngx-pendo.injector.js

I have a PR ready but don't have access to push it...

@yociduo
Copy link
Owner

yociduo commented Dec 25, 2019

You can fork one.

@doronsever
Copy link
Contributor Author

@yociduo you have a PR waiting

@yociduo
Copy link
Owner

yociduo commented Dec 28, 2019

I still want to use RxJS to solve this problem. Pendo script still needs 5 ~ 10 seconds to load in China, which means there will be a long initialization time. This change is in progress and will be released in the next major release
https://github.com/yociduo/ngx-pendo/compare/rxjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants