Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos firefighter gloves + clothing traits refactor #19243

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

SapphicOverload
Copy link
Contributor

@SapphicOverload SapphicOverload commented Jun 12, 2023

Document the changes in your pull request

Adds a new type of gloves for atmos techs. They're fireproof, give fast carry speed, and let you extinguish people with your hands. The CE gets their own that are also electrically insulated as well.

Gloves ported from tgstation/tgstation#72736, also ports tgstation/tgstation#56233 and parts of tgstation/tgstation#73948 to make it easier to add and remove traits when equipping and unequipping items.

Spriting

image

Changelog

🆑 SapphicOverload, Fikou, MrMelbert
rscadd: adds firefighter gloves
tweak: refactors clothing traits
imageadd: adds firefighter glove sprites
/:cl:

@SapphicOverload SapphicOverload requested a review from a team as a code owner June 12, 2023 03:48
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Sprites This PR has spriting changes labels Jun 12, 2023
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@SapphicOverload SapphicOverload changed the title Atmos firefighter gloves Atmos firefighter gloves + clothing traits refactor Jun 12, 2023
code/modules/clothing/gloves/color.dm Outdated Show resolved Hide resolved
@MajManatee
Copy link
Contributor

Feels a bit weird having them be better than the paid traitor gloves, but still cool. Glad they aren't ALL insulated.

@Moltijoe Moltijoe added the Balance Council Approved This PR was approved by the Balance Council. label Jun 13, 2023
@Moltijoe Moltijoe requested a review from a team June 13, 2023 08:07
@Moltijoe
Copy link
Contributor

I like this

should probably actually approve it if you approve the sprite

@MajManatee
Copy link
Contributor

Thank you funny chillean man

@MajManatee MajManatee merged commit 36e4bef into yogstation13:master Jun 14, 2023
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Jun 14, 2023
Yogbot-13 added a commit that referenced this pull request Jun 14, 2023
@SapphicOverload SapphicOverload deleted the atmos-gloves branch May 24, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Council Approved This PR was approved by the Balance Council. Feature This adds new content to the game Sprites This PR has spriting changes Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants