Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public properties in Finite\StateMachine\StateMachine #22

Closed
arikal opened this issue Feb 7, 2014 · 1 comment
Closed

Public properties in Finite\StateMachine\StateMachine #22

arikal opened this issue Feb 7, 2014 · 1 comment

Comments

@arikal
Copy link
Contributor

arikal commented Feb 7, 2014

There are a number of public properties in Finite\StateMachine\StateMachine, most notably $states and $transitions. Are they public for any reason? I can effectively bring down the application by setting them to something bad.

Surely they should be protected?
@arikal
Copy link
Contributor Author

arikal commented Feb 10, 2014

#23

@arikal arikal mentioned this issue Feb 10, 2014
Merged
@yohang yohang closed this as completed May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yohang @arikal