Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floorp --> Yokoffing applied in Floorp --> can't change some settings later. #271

Closed
mahcin opened this issue Jan 8, 2024 · 4 comments · Fixed by #268
Closed

Floorp --> Yokoffing applied in Floorp --> can't change some settings later. #271

mahcin opened this issue Jan 8, 2024 · 4 comments · Fixed by #268
Assignees

Comments

@mahcin
Copy link

mahcin commented Jan 8, 2024

REPORT

Before applying Yokoffing in Floorp settings I have changed for example:

  • "Memory and Performance" via Floorp settings tab to "low performance"
  • "Ask to save logins and passwords for web sites" --> tab ON

Now I have clicked to apply all Yokoffing options in Floorp "Customize Floorp with user.js" setting.
By each "Apply" Floorp restarted.

I wanted to verify&tweak after from Floorp settings menu, but not "about:" level.
I checked:

  • "Memory and Performance" via Floorp settings, it was "best performance", so Yokoffing worked. I have changed this option back to low performance, restarted, re-checked, and it was correct as set myself, "low performance"
  • I went to password option: - "Ask to save logins and passwords for web sites" --> tab was OFF, so Yokoffing worked as should. I changed now "Ask to save logins and passwords for web sites" tab to ON, but couldn't, so I went to about:config to change signon.rememberSignons but I couldn't overwrite it. So, went to user.js and changed there while Floorp wasn't running, switched ON Floorp and it was changed, so browser was able to save passwords again, however, after switching browser OFF and ON again this option was back to original state set by Yokoffing.

Describe the bug
So, after applying Yokoffing in Floorp I can change options later regarding performance, but not all regarding security/passwords.

Expected behavior
Would be nice to be able manually change these settings. This is my personal computer, no one else has access to it, so nice to have Yokoffing, just one click and most security sorted, ten just switch ON option manually to save passwords in Floorp - which cannot do now.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Floorp
  • Version: Version 11.7.1 (64-bit) | Firefox: 115.6.0
    y1
    y2
@mahcin mahcin changed the title Floorp --> Yokoffing applied --> can't change some settings later. Floorp --> Yokoffing applied in Floorp --> can't change some settings later. Jan 8, 2024
@mahcin
Copy link
Author

mahcin commented Jan 8, 2024

To explain more details:
"Yokoffing Securefox" --> "Apply" --> "Ask to save logins and passwords for web sites" --> tab is changed to OFF (as should)
Manually I can change it to ON, it remain ON after restart.

"Yokoffing Default" --> "Apply" --> "Ask to save logins and passwords for web sites" --> tab is changed to OFF (as should)
Manually I can change it to ON, it's switched back to OFF after restart. So I'm unable to change these settings after applying Yokoffing Default

If I do changes manually in user.js then it works fine after Floorp restart, BUT only for one session, another restart and user.js is overwritten unfortunately with default Yokoffing settings.

@yokoffing
Copy link
Owner

For now, I recommend not using the Floorp provided options. Follow the steps for Getting Started and use the user.js. Then add the override to enable the password manager at the bottom.

Note: Betterfox is for Firefox officially, not Floorp.

As the project grows, I should re-consider moving the password manager setting to Optional Hardening instead of disabling it by default.

@yokoffing yokoffing linked a pull request Jan 8, 2024 that will close this issue
@yokoffing
Copy link
Owner

24b21c0

@mahcin
Copy link
Author

mahcin commented Jan 8, 2024

Okay, thank you.
I'm aware of fact that Betterfox is for Firefox and not for Floorp. Thank you for growing this project and making it possible unofficially.
Your manual instruction for Firefox does work for Floorp, just tested.

I went a bit further with testing Yokoffing:

  1. In Floorp --> "Yokoffing Default" --> Apply, then confirmed "OK" in warning box:

Applying a new user.js will overwrite your current user.js file.
Please back up your current user.js file before continuing.

I had no user.js to backup as it wasn't there. Floorp originally is installed without it, however warning box appeared. Now, after Yokoffing, in Floorp profile folder new user.js file was created, previously was no user.js file at all in here.
I'm unable to change content in this user.js file, every single time when Floorp is restarted, user.js is re-created with content of "Yokoffing Default" options and my changes are simply wiped from user.js.
2. Copied in to safe place above user.js which was created by "Yokoffing Default" (untouched).
3. In Floorp --> "Floorp Default" --> Apply, then again confirmed "OK" in warning box:

Applying a new user.js will overwrite your current user.js file.
Please back up your current user.js file before continuing.

Now in Floorp profile folder user.js file completely disappeared. No user.js file in folder at all, even if Floorp notified:

Applying a new user.js will overwrite your current user.js file.
Please back up your current user.js file before continuing.

So at this point settings options must be kept elsewhere then, but by above steps I was able "virtually" copy/paste Yokoffing user.js
4. Copied back to Floorp Yokoffing user.js from step two, now when Yokoffing is not in use really, but "Floorp Default" in use.
5. Restart
6. Done. Now changes made in Floorp regarding saving passwords still doesn't "save" after Floorp restart, however any new changes in copied Yokoffing user.js (incl above password options) does the job and does make changes to Floorp. I noticed this way Yokoffing user.js don't get overwritten. File keep saved changes after restart, changes are noticeable in Floorp, so here is the way of doing it manually with original Yokoffing file of Floorp. So, by this I understand that there is no problem in Yokoffing user.js itself, but somewhere in Floorp or procedure of adding Yokoffing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants