adds support for isc/dshield query of an ip address #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No test? :( |
|
I tested it, it works...trust me :-) On May 3, 2015 5:32:05 PM PDT, Kyle Maxwell notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
test added |
|
Did something break CI? |
|
It's a PR and not in our repo. That should be semi-fixed momentarily when I pull it into a branch from his fork. #lrn2github |
|
Hmmmm that seems like a config issue. It should be doing that. |
|
Passes now, still at 💯 % coverage, no linter issues. 👍 |
krmaxwell
added a commit
that referenced
this pull request
May 5, 2015
adds support for isc/dshield query of an ip address
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spare time on a sunday to contribute the 'lil code attached herein.