Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates non-parsable xcodeproj when a file name contains '@' #24

Closed
ImLaufderZeit opened this issue Aug 22, 2017 · 6 comments · Fixed by tuist/XcodeProj#48
Closed

Comments

@ImLaufderZeit
Copy link

ImLaufderZeit commented Aug 22, 2017

Using XcodeGen 0.3.0 and Xcode 8.3.3.

If one of files name contains "@", xcodegen generates non-parsable project by Xcode, somehow.
So it cannot deal with retina filenames such as foobar@2x.jpg, foobar@3x.jpg.
Adding those kind of assets to *.xcassets wouldn't really solve this problem as I intend not to use it, since using xcassets forces UIImage to be cached.

example:

name: FooBar
targets:
  - name: FooBar
    type: application
    platform: iOS
    sources: 
      - Assets

If "Assets" directory or its subdirectory contains a file that has "@" in its name, Xcode cannot parse generated project.
The other tool, struct, can correctly generates a project in the same situation, just fwiw.

@yonaskolb
Copy link
Owner

Fixed by tuist/XcodeProj#48
Will be in next release

@pepicrft
Copy link

gif

@ImLaufderZeit
Copy link
Author

Amazing! 🤝

@ImLaufderZeit
Copy link
Author

ImLaufderZeit commented Aug 28, 2017

Filename parsing are working flawlessly!
However, now inline script parsing seems to be broken, might be related to this merge...? Should it be an new issue?

@yonaskolb
Copy link
Owner

Oh, yes please file a new issue with your inline script

@ImLaufderZeit
Copy link
Author

Thx, have a look at #41 when you have a time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants