Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying branch name #9

Closed
ryohey opened this issue Oct 4, 2017 · 4 comments
Closed

Add support for specifying branch name #9

ryohey opened this issue Oct 4, 2017 · 4 comments

Comments

@ryohey
Copy link

ryohey commented Oct 4, 2017

version (optional): The git version of the packge. It is usually a tag but can also be a branch. If this is left out the version will default to the latest tag, or if there are no tags then master.

Document says third option string can be branch name.
Haven't you implemented it? It seems to supported only master branch.

} else if string.contains(".") || string == "master" {

I want to implement to support reading branch name other than master.
But I think that the syntax cannot make distinction between command and version in some circumstances.
mint run yonaskolb/xcodegen xcodegen
This can be interpreted as user/repo branch or user/repo command.

Although this does not maintain backward compatibility, I suggest the syntax like user/repo@branch command.

@yonaskolb
Copy link
Owner

Hi @ryohey, any branch is supported. That code you point to is just trying to guess what the second parameter is if you only specify 2.
so you can use something like mint run yonaskolb/xcodegen mybranch xcodegen

Having them be flags would be less ambiguous but more verbose. I like your @ suggestion, though as you say it would be a breaking change

@ryohey
Copy link
Author

ryohey commented Oct 5, 2017

Thanks I understood that this is expected behavior.

@ryohey ryohey closed this as completed Oct 5, 2017
@yonaskolb
Copy link
Owner

@ryohey, the @ behaviour has been added in #11

@ryohey
Copy link
Author

ryohey commented Oct 14, 2017

Ohhhh YES!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants