-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For knitr, the chunk option message = FALSE
will suppress messages now
#25
Comments
No worries I saw a message from CRAN the other day. I will update and resubmit. thanks for reaching out to show what the fix is! |
@yihui I am not sure if I follow where Am I not running the test correctly under the changes to testthat::test_that("thisfile works with knitr", {
testthat::skip_if_not_installed("knitr")
out <- tempfile(pattern = "whereami", fileext = ".md")
testthat::expect_message(
knitr::knit("scripts/thisfile.Rmd", output = out, quiet = TRUE),
normalizePath("scripts/thisfile.Rmd"),
fixed = TRUE
)
}) thanks
|
message = FALSE
will suppress messages now
I was unclear and just modified the issue title here. I meant the chunk option
|
Ah. That makes sense. Thanks for the clarification! |
Just FYI, I added support for the old behavior in evaluate and knitr---you can set |
thanks for the update. I rewrote the test to work around the new functionality and pushed to cran. |
This package is failing on CRAN right now: https://cran.r-project.org/web/checks/check_results_whereami.html The failed test is
whereami/tests/testthat/test-thisfile.R
Line 31 in 64ee46b
This is because a change in the evaluate package: https://github.com/r-lib/evaluate/blob/main/NEWS.md#version-019 That means
message = FALSE
will completely suppress the messages.Sorry for not discovering this earlier (because whereami is not a reverse dependency of evaluate)!
The text was updated successfully, but these errors were encountered: