Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key l deletes files #72

Closed
nkoane opened this issue Apr 22, 2024 · 8 comments
Closed

key l deletes files #72

nkoane opened this issue Apr 22, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@nkoane
Copy link

nkoane commented Apr 22, 2024

Describe the bug
When I press the l key, it deletes the file if it is no longer a folder to go into.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to a file,
  2. Press l

Expected behaviour
Nothing should happen, there is no folder to go into, and therefore nothing should happen (maybe later do a preview or select the file, I don't know)

Screenshots
Not, possible.

System information (please complete the following information):

  • OS: MacOS
  • Version: 14.5
@nkoane nkoane added the bug Something isn't working label Apr 22, 2024
@yorukot
Copy link
Owner

yorukot commented Apr 22, 2024

Can I ask about your current superfile version?

And could you please check the delete_item variable in ~/.config/superfile/hotkeys.toml for me?

@denisbr
Copy link

denisbr commented Apr 22, 2024

I experience the same issue, however I pressed enter instead of l.

❯ brew info superfile
==> superfile: stable 1.1.0 (bottled)
Modern and pretty fancy file manager for the terminal
https://github.com/MHNightCat/superfile
Installed
/opt/homebrew/Cellar/superfile/1.1.0 (6 files, 8.5MB) *
  Poured from bottle using the formulae.brew.sh API on 2024-04-22 at 14:40:24
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/s/superfile.rb
License: MIT
==> Dependencies
Build: go ✔
==> Analytics
install: 109 (30 days), 111 (90 days), 110 (365 days)
install-on-request: 109 (30 days), 110 (90 days), 110 (365 days)
build-error: 0 (30 days)

@denisbr
Copy link

denisbr commented Apr 22, 2024

I was unsure whether it was just a very dangerous default, but I created a temp folder, and made a couple of files, then opened the directory with spf and then pressed enter on these files. They ended up in Trash.

@yorukot
Copy link
Owner

yorukot commented Apr 22, 2024

@denisbr could you please check the delete_item variable in ~/.config/superfile/hotkeys.toml for me?
I'm not sure if this is a coding error or a configuration error
thanks!

I seem to be unable to reproduce this error.

@yorukot
Copy link
Owner

yorukot commented Apr 22, 2024

OK I found the reason.
This error only occurs on macos :(

@yorukot
Copy link
Owner

yorukot commented Apr 22, 2024

@denisbr @nkoane
6572739
This bug has been fixed.
Thanks for your report!

@yorukot
Copy link
Owner

yorukot commented Apr 23, 2024

@yorukot
Copy link
Owner

yorukot commented Apr 23, 2024

If there are still errors in this, please feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants