Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .join() on an empty Vec stalls #153

Closed
michael-temp opened this issue Aug 24, 2023 · 2 comments · Fixed by #154
Closed

Using .join() on an empty Vec stalls #153

michael-temp opened this issue Aug 24, 2023 · 2 comments · Fixed by #154

Comments

@michael-temp
Copy link

Is this the intended behaviour?

futures-concurrency = "7.4.1"
    pub use futures_concurrency::prelude::*;

    #[tokio::test]
    // #[ignore]
    async fn test_join_empty_vec() -> Result<()> {
        Vec::<AbortOnDrop<()>>::new().join().await;

        Ok(())
    }

Result:

running 1 test
        SLOW [>  5.000s] tokio_fixes::tests::test_join_empty_vec
@yoshuawuyts
Copy link
Owner

You're right that this is not the intended behavior. I've posted a patch for it in #154. Thank you for reporting this!

@yoshuawuyts
Copy link
Owner

Fixed in v7.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants