Skip to content
This repository has been archived by the owner on Jan 17, 2020. It is now read-only.

Some need fix? #3

Closed
SuJiKiNen opened this issue Oct 26, 2014 · 5 comments
Closed

Some need fix? #3

SuJiKiNen opened this issue Oct 26, 2014 · 5 comments

Comments

@SuJiKiNen
Copy link

line margin if is set(excepet zero),is force to cover the margin set in style.

@Youka
Copy link
Owner

Youka commented Oct 26, 2014

Could you go in more details?

(When calculating positions, the bigger margin of style & line is choosen.)

@SuJiKiNen
Copy link
Author

line_margin > 0 ? line_margin : style_margin

@Youka
Copy link
Owner

Youka commented Oct 26, 2014

See function call math.max in lines like here.

My parser reads data as they are, so a line/dialog has a margin (like in ASS text) and the related style (styleref) another.
For position calculation, the bigger one is selected, because there it matters.

@SuJiKiNen
Copy link
Author

the subtitle filter don't act this way,and I think line force way is much better,similar to inline fx.

@Youka
Copy link
Owner

Youka commented Oct 26, 2014

Ah, an implementation matter. Fixed it in last commit, thanks.

@Youka Youka closed this as completed Oct 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants