Enable different item label for selected item #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
==========================================
+ Coverage 95.02% 95.03% +<.01%
==========================================
Files 124 124
Lines 2172 2174 +2
==========================================
+ Hits 2064 2066 +2
Misses 108 108
Continue to review full report at Codecov.
|
|
Should fix #845 |
|
Looks good for me ! We just need some tests in this PR. |
mik-laj
reviewed
Aug 14, 2017
| @@ -21,6 +21,7 @@ def get_results(self, context): | |||
| { | |||
| 'id': self.get_result_value(result), | |||
| 'text': self.get_result_label(result), | |||
| 'selected_text': self.get_selected_result_label(result), | |||
There was a problem hiding this comment.
I think it is worth adding this field only if it is different from text. Now one text is sent in two fields even when it is identical.
There was a problem hiding this comment.
That's true but we're going to merge this as is so if you got hard feelings about this then perhaps make another pr or open a ticket 😂
|
Will be in next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds ability to display selected result (in select field) in different way than in dropdown e.g. display detail item in dropdown but only name in field after selection.