Problem with limitation of choices_for_values #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforcing a limitation on the choices available to the already selected values also enforces a limit on the amount of values which can be selected. For example a limit_choices value of 20 would result in an error if more than 20 values were selected using the autocompletion feature. Removing the limit also removes this corner-case problem.
jpic
added a commit
that referenced
this pull request
Nov 2, 2012
Limiting choices in choices_for_values makes no sense, it is only needed in choices_for_request.
|
Thanks for your bugfix ! Released in 1.1.0. |
|
And welcome to AUTHORS B) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforcing a limitation on the choices available to the already selected values also enforces a limit on the amount of values which can be selected. For example a limit_choices value of 20 would result in an error if more than 20 values were selected using the autocompletion feature. Removing the limit also removes this corner-case problem.