Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable for configuring YOURLS_NOSTATS #29

Closed
vitalyzhakov opened this issue Jul 4, 2019 · 2 comments · Fixed by #30
Closed

Add environment variable for configuring YOURLS_NOSTATS #29

vitalyzhakov opened this issue Jul 4, 2019 · 2 comments · Fixed by #30
Labels
enhancement New feature or request

Comments

@vitalyzhakov
Copy link
Contributor

vitalyzhakov commented Jul 4, 2019

Hello!

Summary
Our installation of short link must serve about 1,1 millions of links per month.
I see big log table after stress testing.

I decide disable stats in db to decrease heavy load.

Describe the solution you'd like
In basic yourls config we may set this option, https://github.com/YOURLS/YOURLS/blob/master/includes/Config/Config.php#L196-L198, but in docker image - not.
I want to configure this option by environment variable.

@vitalyzhakov vitalyzhakov added the enhancement New feature or request label Jul 4, 2019
@LeoColomb
Copy link
Member

Thanks @vitalyzhakov for this report!

Do you mount the volume? If so, I would prefer to suggest editing your own config.php.

@vitalyzhakov
Copy link
Contributor Author

vitalyzhakov commented Jul 6, 2019

@LeoColomb , hello!
For high avaliability we start at least 2 container instance in one datacenter (docker swarm). It does not have any volumes, configuration changed by environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants