Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Icon: name not work when passing url #2585

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

rex-zsd
Copy link
Contributor

@rex-zsd rex-zsd commented Jan 22, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2585 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2585   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         104      104           
  Lines        1896     1896           
  Branches      188      188           
=======================================
  Hits         1652     1652           
  Misses        213      213           
  Partials       31       31
Impacted Files Coverage Δ
packages/icon/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b698e5...c8383ac. Read the comment docs.

@chenjiahan chenjiahan changed the title [bugfix] Icon: 修复name为url时不显示 [bugfix] Icon: name not work when passing url Jan 22, 2019
@chenjiahan chenjiahan merged commit b2d86fa into youzan:dev Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants