Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new feature] Popup: add opened/closed event #2650

Merged
merged 3 commits into from
Jan 30, 2019
Merged

[new feature] Popup: add opened/closed event #2650

merged 3 commits into from
Jan 30, 2019

Conversation

chenjiahan
Copy link
Member

No description provided.

@chenjiahan chenjiahan merged commit 01c893a into youzan:dev Jan 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #2650 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #2650      +/-   ##
=========================================
+ Coverage   87.99%     88%   +<.01%     
=========================================
  Files         104     104              
  Lines        1958    1959       +1     
  Branches       52      52              
=========================================
+ Hits         1723    1724       +1     
  Misses        218     218              
  Partials       17      17
Impacted Files Coverage Δ
packages/popup/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466bb3c...9628cb6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants