Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales (translations) are not included in the dist package #52

Closed
interDist opened this issue Jan 31, 2019 · 4 comments
Closed

Locales (translations) are not included in the dist package #52

interDist opened this issue Jan 31, 2019 · 4 comments

Comments

@interDist
Copy link
Contributor

Installing from PyPI results in no localisations being available.

@yprez
Copy link
Owner

yprez commented Jul 30, 2019

Fixed in #54, sorry for the delay...

@yprez yprez closed this as completed Jul 30, 2019
@interDist
Copy link
Contributor Author

Hey @yprez , I finally got to explore the reason why the locale files are not there even in 1.0.5. They are in the downloadable tar.gz but are missing in the wheel.

I think the reason is a faulty setup.py script. You have packages=['logentry_admin'] instead of packages=['logentry_admin', 'logentry_admin.locale'] or packages=find_packages() (see https://stackoverflow.com/a/54357929). This results in the following output when running pip in verbose mode, and the locale files are clearly skipped:

adding 'logentry_admin/__init__.py'
adding 'logentry_admin/admin.py'
adding 'logentry_admin/models.py'
adding 'logentry_admin/templates/admin/admin/logentry/change_form.html'
adding 'django_logentry_admin-1.0.5.dist-info/LICENSE.txt'
adding 'django_logentry_admin-1.0.5.dist-info/METADATA'
adding 'django_logentry_admin-1.0.5.dist-info/WHEEL'
adding 'django_logentry_admin-1.0.5.dist-info/top_level.txt'
adding 'django_logentry_admin-1.0.5.dist-info/RECORD'

@yprez yprez reopened this Dec 31, 2019
@yprez
Copy link
Owner

yprez commented Dec 31, 2019

@interDist nice catch!
For some reason find_packages() returns ['tests', 'logentry_admin']
I'll take a look at it and release a new version when I get a chance...

@yprez
Copy link
Owner

yprez commented Apr 23, 2020

Fixed :)

@yprez yprez closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants