Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failing #27

Closed
gamer191 opened this issue Jun 22, 2022 · 12 comments
Closed

Builds failing #27

gamer191 opened this issue Jun 22, 2022 · 12 comments

Comments

@gamer191
Copy link

gamer191 commented Jun 22, 2022

Patch one is not applying on the master builds

EDIT: Actually, it appears that patch one was applied to master in FFmpeg/FFmpeg@cc5844d, so it can probably just be deleted

EDIT 2: Actually, it appears (I didn't look super closely) that all 5 patches were merged into master:
Patch 1-FFmpeg/FFmpeg@cc5844d
Patch 2-FFmpeg/FFmpeg@dfa062e
Patch 3-FFmpeg/FFmpeg@13350e8
Patch 4-FFmpeg/FFmpeg@c381f54
Patch 5-FFmpeg/FFmpeg@69364a0
In my opinion this repo should stay up though, so that all most yt-dlp users use the same builds, with the same codecs compiled, and we won't encounter any issues of people using ffmpeg lite etc. Also, this repo should stay up for when #26 gets merged

@pukkandan pukkandan pinned this issue Jun 22, 2022
@nihil-admirari
Copy link
Collaborator

nihil-admirari commented Jun 22, 2022

all 5 patches were merged into master

True.

Also, this repo should stay up for when #26 gets merged

Merged.

@pukkandan
Copy link
Member

Keeping this pinned so that a new issue doesn't need to be opened every time a rebase fails

@gamer191
Copy link
Author

gamer191 commented Jul 14, 2022

The rebase is failing again, because of a merge conflict in the .gitignore file

@pukkandan
Copy link
Member

fixed

@gamer191
Copy link
Author

The builds are failing again :(

@nihil-admirari
Copy link
Collaborator

Upstream problem: BtbN#182.

@gamer191
Copy link
Author

gamer191 commented Aug 18, 2022

Thanks @nihil-admirari
On a side note, it's been fixed upstream, BtbN@512e0fe, so now I guess it's just a matter of waiting for the next Rebase on Upstream (in approximately 9 hours)

@gamer191
Copy link
Author

gamer191 commented Aug 18, 2022

Rebase on Upstream is failing again, due to a conflict with BtbN@d4de051
That said, there's no urgency to fix it, because Pukkandan manually ran Rebase on Upstream earlier, so 512e0fe has already made it's way onto this repo (Build FFmpeg is running right now, fingers crossed it succeeds)

EDIT: it's working again :)

@pukkandan pukkandan unpinned this issue Mar 28, 2023
@gamer191
Copy link
Author

The builds are failing again

@nihil-admirari
Copy link
Collaborator

Must be fixed upstream: BtbN@915d6e0#commitcomment-115905755.

@gamer191
Copy link
Author

The builds are failing again, although the error message makes it sound like it's an issue on Github's end

@gamer191
Copy link
Author

The builds are failing every few days with connection reset by peer. I'm not sure if I should report that here or open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants