New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build:Makefile] Ensure compatibility with BSD make
#9210
Conversation
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefiles are great 👍
@@ -141,6 +143,7 @@ yt-dlp.tar.gz: all | |||
--exclude '__pycache__' \ | |||
--exclude '.pytest_cache' \ | |||
--exclude '.git' \ | |||
--exclude '__pyinstaller' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? User should be able to run pyinstaller from source tar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was, fixed in 43cfd46
Authored by: bashonly
BSD Make can't do
$(shell ...)
. We were already using it in theMARKDOWN
andSYSCONFDIR
vars, but by using it inCODE_FOLDERS
andCODE_FILES
I broke theyt-dlp
target for bmake.Also:
yt-dlp
target if bmake is run in jobs modeSYSCONFDIR
var assignment__pyinstaller
subdir from tarballGNU Make versions older than 4.0 don't support
!=
, but considering that gmake 4.0 was released in 2013 IMO we shouldn't need to support it. Apparently Debian was holding onto make 3.8x for a while, but as of Jessie it was bumped to 4.0 (and all Debian versions up-to-and-including Jessie ship EOL Python anyways). CentOS 7 still has make 3.8x, but it is EOL as of the end of June.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?