Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtve] Add support for audio only #1657

Merged
merged 11 commits into from
Dec 21, 2021
Merged

[rtve] Add support for audio only #1657

merged 11 commits into from
Dec 21, 2021

Conversation

kebianizao
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This adds support to audio only urls to the rtve extractor. So far this extractor did not support urls like Audio only episode . With this extension such audio only url is supported.

The class supporting the above mentioned url includes a test case which runs successfully here.

Taken over from ytdl-org/youtube-dl#29023

yt_dlp/extractor/extractors.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rtve.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rtve.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rtve.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rtve.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Nov 18, 2021
kebianizao and others added 2 commits November 21, 2021 23:07
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@kebianizao
Copy link
Contributor Author

Thanks for the review. I think I've addressed all comments, but let me know if you see anything else.

@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Nov 22, 2021
Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks good

yt_dlp/extractor/rtve.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rtve.py Show resolved Hide resolved
@pukkandan pukkandan added pending-fixes PR has had changes requested site-enhancement Feature request for some website labels Nov 30, 2021
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Dec 21, 2021
@pukkandan pukkandan merged commit 5edb8df into yt-dlp:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants