New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rtve] Add support for audio only #29023
base: master
Are you sure you want to change the base?
Conversation
Read coding conventions. |
Also, with the new redesign this no longer works for downloading. Now you need to do the same thing that the video downloader does (i. e. get the formats from the png using |
Thanks for the comments, Sukil. I've addressed somehow the problems of the new urls (just pushed), but I'll look further into your suggestions. Regards, |
Weird, seems like with your test it works, but with other radio programs it doesn't and you have to take the |
Thanks for your comment. I guess it is possible to improve something or fetch more information about the media, but I have tried some other urls and they work:
Could you let me know of any that it is not working so I can test proof it myself? |
I've taken a look at those examples. The problem is that the json provided by the rtve api service https://www.rtve.es/api/audios/<id>.json does not contain the final media url in some cases, for instance, in the json section page.items[0].qualities[0]
|
I've already explained the correct method. Look at how the video extractor does it, and do the same thing, changing |
Sorry not considering you advice, I now see png decrypt is required (by the way, extracting info like this is insane). I have pushed a first approach. I now need to refactor it more properly. |
FYI I've moved to yt-dlp. I moved the PR to yt-dlp/yt-dlp#1657 Feel free to follow-up there. |
Original PR: ytdl-org/youtube-dl#29023 Authored by: kebianizao
Closing as PR is already merged. |
I'd rather keep it open to remind us to implement the functionality here, but probably by pulling the dlp code. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This adds support to audio only urls to the rtve extractor. So far this extractor did not support urls like Audio only episode . With this extension such audio only url is supported.
The class supporting the above mentioned url includes a test case which runs successfully here.