New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie] Add new fields with proper support for multiple values #8917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
added
enhancement
New feature or request
core-triage
triage requested from a core dev
labels
Jan 3, 2024
Could you split it into a new PR? I can merge the rest asap, but this part needs further discussion. Your impl is not matching what we discussed previously
Let's go with |
pukkandan
requested changes
Jan 3, 2024
pukkandan
reviewed
Jan 3, 2024
pukkandan
reviewed
Jan 3, 2024
pukkandan
reviewed
Jan 3, 2024
pukkandan
reviewed
Jan 3, 2024
9 tasks
- Moved fix_deprecated_fields into _fill_common_fields
9 tasks
pukkandan
reviewed
Jan 3, 2024
pukkandan
approved these changes
Jan 12, 2024
seproDev
reviewed
Jan 28, 2024
9 tasks
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
gmes78
added a commit
to gmes78/yt-dlp
that referenced
this pull request
Feb 21, 2024
gmes78
added a commit
to gmes78/yt-dlp
that referenced
this pull request
Feb 21, 2024
gmes78
added a commit
to gmes78/yt-dlp
that referenced
this pull request
Feb 21, 2024
9 tasks
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: llistochek, pukkandan Related: yt-dlp#3944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
Partially fixes #3944 (We need to add support in extractors themselves).
Changes:
artist_list
composer_list
genre_list
album_artist_list
fix_deprecated_fields
, which converts deprecated fields into their new counterpart , splitting them by comma.composer
add
function inside_get_metadata_opts
to support listsMutagenMetadataPP
. It runs just afterFFMpegMetadataPP
and overrides ffmpeg-written metadata with properly formatted values. It writes only new (*_list
) fields.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?