Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie] Add new fields with proper support for multiple values #8917

Merged
merged 28 commits into from Feb 20, 2024

Conversation

llistochek
Copy link
Contributor

Description of your pull request and other information

Partially fixes #3944 (We need to add support in extractors themselves).

Changes:

  • [InfoExtractor] Added new fields:
    • artist_list
    • composer_list
    • genre_list
    • album_artist_list
  • [InfoExtractor] Reflected changes in documentation
  • [YoutubeDL] Added new function fix_deprecated_fields, which converts deprecated fields into their new counterpart , splitting them by comma.
  • [FFMpegMetadataPP] Replaced all usages of deprecated fields with new, added support for composer
  • [FFMpegMetadataPP] Slightly changed add function inside _get_metadata_opts to support lists
  • Added new post processor MutagenMetadataPP. It runs just after FFMpegMetadataPP and overrides ffmpeg-written metadata with properly formatted values. It writes only new (*_list) fields.
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added enhancement New feature or request core-triage triage requested from a core dev labels Jan 3, 2024
@pukkandan
Copy link
Member

pukkandan commented Jan 3, 2024

  • Added new post processor MutagenMetadataPP. It runs just after FFMpegMetadataPP and overrides ffmpeg-written metadata with properly formatted values. It writes only new (*_list) fields.

Could you split it into a new PR? I can merge the rest asap, but this part needs further discussion. Your impl is not matching what we discussed previously

  • artist_list
  • composer_list
  • genre_list
  • album_artist_list

Let's go with artists, composers etc. And update the fields in readme too https://github.com/yt-dlp/yt-dlp#outtmpl-postprocess-note

yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/extractor/common.py Outdated Show resolved Hide resolved
yt_dlp/extractor/common.py Outdated Show resolved Hide resolved
yt_dlp/extractor/common.py Outdated Show resolved Hide resolved
yt_dlp/extractor/common.py Outdated Show resolved Hide resolved
yt_dlp/postprocessor/ffmpeg.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
@pukkandan pukkandan mentioned this pull request Jan 3, 2024
9 tasks
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
yt_dlp/YoutubeDL.py Outdated Show resolved Hide resolved
@pukkandan pukkandan removed the core-triage triage requested from a core dev label Jan 12, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@pukkandan pukkandan merged commit 104a7b5 into yt-dlp:master Feb 20, 2024
15 checks passed
gmes78 added a commit to gmes78/yt-dlp that referenced this pull request Feb 21, 2024
gmes78 added a commit to gmes78/yt-dlp that referenced this pull request Feb 21, 2024
gmes78 added a commit to gmes78/yt-dlp that referenced this pull request Feb 21, 2024
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ; as separator for metadata instead of , for vorbis comments and / for ID3
4 participants