[rh:websockets] Add support for HTTP/HTTPS proxies #9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts' into networking/websockets-http-proxy
…ts' into networking/websockets-http-proxy # Conflicts: # test/test_http_proxy.py
coletdjnz
added
bug
coletdjnz
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
9 tasks
coletdjnz
commented
Apr 6, 2024
coletdjnz
commented
Apr 6, 2024
coletdjnz
commented
Apr 6, 2024
coletdjnz
commented
Apr 6, 2024
pukkandan
reviewed
Apr 10, 2024
Comment on lines
+44
to
+48
| urllib3_supported = False | ||
| urllib3_version = tuple(int_or_none(x, default=0) for x in urllib3.__version__.split('.')) if urllib3 else None | ||
| if urllib3_version and urllib3_version >= (1, 26, 17): | ||
| urllib3_supported = True | ||
|
|
There was a problem hiding this comment.
this check should be moved to dependencies.py as we discussed on discord
There was a problem hiding this comment.
will create another PR for this - out of scope for this one
10 tasks
this ensures it is used for both sockets in TLS-in-TLS
(so it is used for both ends of tls-in-tls)
coletdjnz
commented
May 18, 2024
pukkandan
reviewed
May 18, 2024
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Depends on #9578
--proxyand websockets is installed #9509Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?