Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add http proxy tests #9578

Merged
merged 9 commits into from
May 10, 2024

Conversation

coletdjnz
Copy link
Member

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

  • adds tests for http/https proxies (standard and CONNECT)
  • fixes https proxies in curl-cffi
  • various minor test suite improvements
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@coletdjnz coletdjnz added bug Bug that is not site-specific networking core networking related labels Mar 31, 2024
test/test_http_proxy.py Dismissed Show dismissed Hide dismissed
test/test_http_proxy.py Fixed Show fixed Hide fixed
test/test_http_proxy.py Dismissed Show dismissed Hide dismissed
test/test_http_proxy.py Dismissed Show resolved Hide resolved
@coletdjnz
Copy link
Member Author

One of the tests were failing for Requests due to a potential bug in urllib3. I've skipped it for requests for now.

urllib3/urllib3#3374

@coletdjnz coletdjnz merged commit 3c7a287 into yt-dlp:master May 10, 2024
15 checks passed
@coletdjnz coletdjnz deleted the networking/add-http-proxy-tests branch May 10, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific networking core networking related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant