Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching? #9

Open
fwolfst opened this issue Mar 1, 2019 · 0 comments
Open

Implement caching? #9

fwolfst opened this issue Mar 1, 2019 · 0 comments

Comments

@fwolfst
Copy link
Contributor

fwolfst commented Mar 1, 2019

I just stumbled around https://www.lugolabs.com/articles/render-markdown-views-with-redcarpet-and-pygment-in-rails . I like the class setup (#erb with memoization, #markdown, #render and #call, but imho should add #redcarpet_options) and he or she is adding caching functionality at the very and of the article. Sounds like a very low hanging fruit.

I havent done any caching research, in able to render a markdown file with different renderers (e.g. TOC), I guess the cache key should not be generated only from the file content, but also from another value like :emd_redcarped_md` or something like that, but really just guessing here.

I am a bit pessimistic that I will find time to craft a PR.

Are we up to emd 0.2.0? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant