Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deezer download #31075

Open
Marcioghiraldelli opened this issue Jul 7, 2022 · 11 comments
Open

deezer download #31075

Marcioghiraldelli opened this issue Jul 7, 2022 · 11 comments
Labels
site-support-request Add extractor(s) for a new domain

Comments

@Marcioghiraldelli
Copy link

Hello, I notice that deezer download works well, but it only downloads 30 seconds of audio. Is there an alternative to this?

@dirkf
Copy link
Contributor

dirkf commented Jul 8, 2022

See yt-dlp/yt-dlp#1591.

@Marcioghiraldelli
Copy link
Author

@dirkf as I understand it, it will not be possible more than 30 seconds, right?

@dirkf
Copy link
Contributor

dirkf commented Jul 8, 2022

The original PR, mentioned in the link, is apparently invalid, in that it no longer matches what the site does. It does contain a Blowfish crypto module that might still be useful, here or elsewhere.

The discussion in the linked issue indicates that it might be possible to develop a PR that extracts the full tracks without DMCA infringement but it would have to be carefully assessed. Personally, I won't be doing this but others are welcome to try, whether for personal use or as a PR, subject to the considerations I mentioned.

@Marcioghiraldelli
Copy link
Author

@89z I liked your idea.
Do you have information on how to use your extractor?

@Marcioghiraldelli
Copy link
Author

@LucBerge
Copy link

LucBerge commented Aug 5, 2022

Hello,
I was able to fix the deezer extractor, and uncypher the files. My PR was never merged and then the repo was taken down. I'll try to fix it in September.

See #22074

@LucBerge
Copy link

LucBerge commented Aug 5, 2022

Correction. It seems the DMCA in question was for YouTube-DL itself, and some forks:

https://github.com/github/dmca/blob/master/2020/10/2020-10-23-RIAA.md

since we all know that challenge ultimately failed, then it might be fine to add a Deezer extractor at this point, since it was RIAA and not Deezer that made the claim.

Indeed, it wasn't taken down because of me. I should have specify it...

However, my implementation is not "correct" since I bypass the authentication !

@LucBerge
Copy link

LucBerge commented Aug 5, 2022

Wait a minute, my code was merged to yt-dlp from my fork of youtube-dl

This is my code 😄 . Does it still work ?

Edit: This is not the latest version of my code. It does not support full song and uncypher. The fork have been made too early of from the wrong branch of my repo.

Edit 2: The merged branch was deezer while the full song support was on the deezer-uncypher branch as stayed here.

@dirkf
Copy link
Contributor

dirkf commented Aug 5, 2022

As above, the question is whether PR #22074 still works.

Easiest is if you can get your repo unblocked (quote #27013), test the branch and commit any necessary changes to match the site there. Otherwise you can clone the PR code into a new branch and make a replacement PR from it (with whatever necessary changes).

@dirkf dirkf added the site-support-request Add extractor(s) for a new domain label Aug 21, 2022
@LucBerge
Copy link

@dirkf I could not get my repo unlocked. Check this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-support-request Add extractor(s) for a new domain
Projects
None yet
Development

No branches or pull requests

4 participants
@dirkf @LucBerge @Marcioghiraldelli and others