Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json powered youtube-dl #70

Closed
Cightline opened this issue Feb 7, 2011 · 1 comment
Closed

json powered youtube-dl #70

Cightline opened this issue Feb 7, 2011 · 1 comment

Comments

@Cightline
Copy link

Advantages:
Faster, less code, more options and data via the API.

One way of implementing this would be to have youtube-dl preform a try/except statement and attempt to import json when it is updating. If it does not throw an exception, then it will update to the json version. Otherwise it will update to the json-less version.

Another way would be to include the json code into youtube-dl, but this will increase the size, and probably include more if/else statements. Although once it detects json, it will be able to use it as normal.

This could be the way to provide compatibility with Python 2.5 while enhancing/optimizing
2.6+

@rg3
Copy link
Collaborator

rg3 commented Feb 7, 2011

Not interested for now. While the code can be a bit simpler, most time is spent downloading the videos themselves. JSON may be used in the future, but we won't maintain two versions of the same code, which is the only sane way to provide backwards compatibility.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants