Added master caches support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose that tests are failing because of yamls wasn't updated. I suppose make generate will fix that. |
l0kix2
requested changes
Feb 23, 2024
qurname2
force-pushed
the
master_caches_support
branch
2 times, most recently
from
5a9df63
to
8d66b57
Compare
qurname2
force-pushed
the
master_caches_support
branch
from
0cc20aa
to
3444743
Compare
l0kix2
requested changes
Mar 12, 2024
…ell. Wrote test for getMasterCachesConfig and small improvements
qurname2
force-pushed
the
master_caches_support
branch
from
23e598c
to
70b33e5
Compare
l0kix2
requested changes
Mar 13, 2024
| c.MasterCache.Addresses = g.getMasterAddresses() | ||
| } else { | ||
| c.MasterCache.Addresses = g.getMasterCachesAddresses() | ||
| } |
There was a problem hiding this comment.
Looks like default behaviour to go to master if master caches is empty. @gritukan is it better somehow to fill config with master addresses for caches for some reason?
l0kix2
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve issue #94