Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coresMin used instead of ramMin #26

Closed
biokcb opened this issue Aug 9, 2018 · 1 comment
Closed

coresMin used instead of ramMin #26

biokcb opened this issue Aug 9, 2018 · 1 comment

Comments

@biokcb
Copy link

biokcb commented Aug 9, 2018

Hi,

We were testing using the ResourceRequirement field in the CWL document and noticed that when using ramMin the sub command submits -R mem>coresMin

Looks like the error is likely simply fixed here by replacing coresMin with ramMin: https://github.com/IBMSpectrumComputing/cwlexec/blob/e3c19121ac9ec8db24f09c542931345a43bb4ef0/src/main/java/com/ibm/spectrumcomputing/cwl/exec/service/CWLLSFCommandServiceImpl.java#L177

Attached is a test case. Even though ramMin is set to 100, it uses coresMin (either the given value or null if it is not given where it produces an error).

ramMinError.tar.gz

@skeeey
Copy link
Collaborator

skeeey commented Aug 10, 2018

Oh, it is an obvious error :-), has fixed at 6bbb51d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants