Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Equalizer does not propagate updates? #135

Closed
ivanbiljan opened this issue Oct 19, 2022 · 4 comments
Closed

[Bug]: Equalizer does not propagate updates? #135

ivanbiljan opened this issue Oct 19, 2022 · 4 comments
Assignees
Labels
🐞Buggy Bug Buggy bug buggies.

Comments

@ivanbiljan
Copy link

Describe your issue in as much detail as possible

I'm using the equalizer as a bass booster. Boosting works fine, however resetting a boosted stream does not. See image below:
image

Setting the boost to BassBoost.High produces expected results with audios such as https://www.youtube.com/watch?v=ft5X5wVBcYQ&ab_channel=UltimateBassBooster, i.e. ,there's a noticeable difference in the strength of the bass.

However, if I try to revert to original state by setting the boost to None (0 gain) nothing happens

Version

v5 (Latest)

Version

GitHub's latest

Relevant log output

No response

@ivanbiljan ivanbiljan added the 🐞Buggy Bug Buggy bug buggies. label Oct 19, 2022
@Yucked
Copy link
Owner

Yucked commented Oct 19, 2022

Unsure if it gets ignored because 0.0 is default value. Try -0.1 and see if that works

@ivanbiljan
Copy link
Author

Right, I saw the JsonIgnore, however I forgot to mention that I tried going from -0.25 to 0.35 and that didn't work either unfortunately

@ivanbiljan
Copy link
Author

For whatever it's worth I just tested this against the v6 branch and it seems to work as intended

@Yucked
Copy link
Owner

Yucked commented Dec 15, 2022

If it's working on v6 then it's all good. v5 won't be maintained anymore

@Yucked Yucked closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞Buggy Bug Buggy bug buggies.
Projects
None yet
Development

No branches or pull requests

2 participants