Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Some video make Victoria throw a silent exception, making all event not tigger anymore #140

Closed
AlexandreBazeaud opened this issue Jan 24, 2023 · 1 comment
Closed

[ BUG ] Some video make Victoria throw a silent exception, making all event not tigger anymore #140

AlexandreBazeaud opened this issue Jan 24, 2023 · 1 comment
Assignees
@Yucked
Labels
🐞Buggy Bug Buggy bug buggies.

Comments

@AlexandreBazeaud
Copy link
Contributor

Describe the bug/issue.

Exception is produced at LavaNode.cs line 363, the data received contain unparsable json. When this silent exception is thrown (because JsonDocument.Parse is not in the try catch) any event going forwards will not be handled at all, forcing a restart of the all application.

Stacktrace / Screenshots

image

Solution

The bug seems to be reproducable 100% using this link https://www.youtube.com/watch?v=Ksl04qNkkRM, encodedTrack is too big and bufferSize is too small, causing the Json received to miss mandatory characters to be parsable, the solution is to increase BufferSize
@AlexandreBazeaud AlexandreBazeaud added the 🐞Buggy Bug Buggy bug buggies. label Jan 24, 2023
AlexandreBazeaud added a commit to AlexandreBazeaud/Victoria that referenced this issue Jan 24, 2023
@AlexandreBazeaud
Increase buffer size Yucked#140
e42dcd9
@AlexandreBazeaud AlexandreBazeaud mentioned this issue Jan 24, 2023
Closed
@Yucked
Copy link
Owner

Yucked commented Feb 10, 2023

fixed in recent commit

@Yucked Yucked closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yucked Yucked

Labels
🐞Buggy Bug Buggy bug buggies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase buffer size #140 AlexandreBazeaud/Victoria
2 participants
@Yucked @AlexandreBazeaud