[DOCS] add replace yb-master docs #4791
Conversation
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
… doc-replace-master
…yte-db into doc-replace-master
|
@stevebang did all requested changed |
… doc-replace-master
| To start `yb-master` in standby mode, set the `--master_addresses` flag to an empty string (`""`). | ||
|
|
||
| ```sh | ||
| ./bin/yb-master --master_addresses="" |
There was a problem hiding this comment.
not sure if this might end up being confusing to users, if they already have a bunch of other necessary flags, like placement options, fs_data_dirs, etc
I wouldn't want folks to assume this is all the flags they need to bring the master up, but I'm not sure how we're handling that in other sections?
There was a problem hiding this comment.
Reworded like it's explained here: https://docs.yugabyte.com/latest/manage/change-cluster-config/#2-start-yb-master-servers
There was a problem hiding this comment.
IMO, now it's actually a bit more confusing, as we're talking about the flag being set to empty string AND the flag not being set, in the same sentence...which for a simple user, could be 2 different things.
What I was thinking was, the command we highlight should either:
- not include
--master_addresses-- and then the messaging above should say just don't provide it - include
--master_addresses=""-- and the messaging should say set it to empty string
But moreover, the command should maybe also include something like
--fs_data_dirs=<your data directories>
[any other flags you would normally pass to this master process]
There was a problem hiding this comment.
Pushed change with --master_addresses=""
| ``` | ||
| {{< note title="Note" >}} | ||
|
|
||
| Make sure to specify all YB-Master addresses which will prevent the new YB-Master server from unexpectedly becoming the leader. |
There was a problem hiding this comment.
hmm, the end part of this comment does not make sense...you need to specify M4, not to prevent it from becoming the leader (this command cannot affect that), but instead, to make sure that, if it DID become the leader in the meantime, then yb-admin can find it
There was a problem hiding this comment.
Check change here 67996cc ?
|
@bmatican made all requested changes, please recheck |
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Fixes #4676
Screenshot:
