Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] add replace yb-master docs #4791
[DOCS] add replace yb-master docs #4791
Changes from 12 commits
8c1c525
12f8a53
45fe032
69432c5
9aacb83
fdffc1c
9dd9a08
674174f
76729c7
54962e4
e32b014
d950ef4
34d4435
0761470
ddf04ef
67996cc
96afa87
2849ae3
6568157
7d6017b
f752eff
80c100d
ceac034
92959e5
2e2a24f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this might end up being confusing to users, if they already have a bunch of other necessary flags, like placement options, fs_data_dirs, etc
I wouldn't want folks to assume this is all the flags they need to bring the master up, but I'm not sure how we're handling that in other sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded like it's explained here: https://docs.yugabyte.com/latest/manage/change-cluster-config/#2-start-yb-master-servers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, now it's actually a bit more confusing, as we're talking about the flag being set to empty string AND the flag not being set, in the same sentence...which for a simple user, could be 2 different things.
What I was thinking was, the command we highlight should either:
--master_addresses
-- and then the messaging above should say just don't provide it--master_addresses=""
-- and the messaging should say set it to empty stringBut moreover, the command should maybe also include something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed change with
--master_addresses=""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, the end part of this comment does not make sense...you need to specify M4, not to prevent it from becoming the leader (this command cannot affect that), but instead, to make sure that, if it DID become the leader in the meantime, then yb-admin can find it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check change here 67996cc ?