Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist paste event for node #1350

Merged
merged 1 commit into from
Nov 13, 2013
Merged

whitelist paste event for node #1350

merged 1 commit into from
Nov 13, 2013

Conversation

JetFault
Copy link
Contributor

It was whitelisted for the plugins instance of YUI, but not for the YUI that is used by this entire module.

Before, no paste events were ever caught by this module. Now they are caught and the _DOMPaste function actually runs. Try in the tests :)

How to reproduce: put a breakpoint on _DOMPaste, copy paste into RTE, never runs.

@clarle
Copy link
Collaborator

clarle commented Nov 10, 2013

@apipkin Can you confirm the fix for this issue?

If it's alright, I'll write the test to replicate @JetFault's issue and we'll merge this in.

@ezequiel
Copy link
Contributor

@clarle,

No, this is not the correct fix for this issue. And no, a test does not need to be written for white listed events. They simply distinguish between what is a native and custom event.

@JetFault,

Thanks. If you wish to white list the paste event for Node, then it should be done here: node-event.

If paste is going to be added to the list, you may as well add copy and cut.

@JetFault
Copy link
Contributor Author

@ezequiel This is what I preferred to do, but didn't know if y'all want to whitelist those events for all dom nodes.

Should i make a PR adding those events?

@ezequiel
Copy link
Contributor

Sure.

@JetFault
Copy link
Contributor Author

@ezequiel How does this look?

@ezequiel ezequiel merged commit a461c6a into yui:dev-master Nov 13, 2013
@ezequiel
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants