-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS - Don't strip spacing before !important #37
Comments
Fix issue #37 (removing spaces on !important)
This was merged into 2.4.8 |
@tml @namanyayg Could you provide any examples where stripping a space before '!important' leads to a broken styling? We got the similar request in https://github.com/GoalSmashers/clean-css but without a test case it's not possible to verify if you made a mistake or if there is a very specific case where the space has to be there. According to our tests it is OK to get rid of it. What's more such code has been used in production for couple years now without any issues. |
Can we get some background or data on this, or revert the change? Without any more information, this seems like a needless regression. We've also been using 2.4.7 for a while now in production without issue. |
I can confirm that this space is important in some browsers / mail clients. Outlook 2007 is definitely effected by this. |
Also, although its not in the spec that a space should be present, all of their examples have it. |
So you punish all other browsers because of Outlook 2007? |
Yes. And punish? Hardly. The rule shouldn't really be used anyway. But its required to fix bad implementations of browers etc. eg. Outlook 2007 etc. |
If you consider Outlook 2007 a browser then good for you. 👍 |
@GoalSmashers Really? I even stated bad implementations of browsers. Outlook makes up for a huge percentage of the mail client market share. |
The change to the screen.css file is due to the following issue: CSS - Don't strip spacing before !important yui/yuicompressor#37
The change to the screen.css file is due to the following issue: CSS - Don't strip spacing before !important yui/yuicompressor#37
If
!important
is used on css declarations, the whitespace before it is stripped, rendering the whole important and the declaration obsolete.The text was updated successfully, but these errors were encountered: