Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*ApiError return types should change to error #6

Closed
ghost opened this issue Feb 23, 2015 · 0 comments
Closed

*ApiError return types should change to error #6

ghost opened this issue Feb 23, 2015 · 0 comments
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Feb 23, 2015

When reusing error variables with gopher-lua, the "Why is my nil error value not equal to nil?" issue arises.

It would be a good idea to change any *ApiError return value to error to prevent this from happening. Most Go libraries take this approach (e.g. 1, 2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuin