Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninja generator is not aware of VCLinkerTool.GenerateManifest #389

Closed
GoogleCodeExporter opened this issue Apr 19, 2015 · 1 comment
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Generate ninja build file from following gyp file
2. ninja -C out/Default hello

What is the expected output? What do you see instead?
Actual: hello.exe.manifest is generated.
Expected: hello.exe does not have any manifest file.
msvs generator does not have this issue.

Please use labels and text to provide additional information.

{
  'targets': [
    {
      'target_name': 'hello',
      'type': 'executable',
      'sources': ['hello.cc'],
      'msvs_settings': {
        'VCLinkerTool': {
          'EnableUAC': 'true',
          'GenerateManifest': 'false',
        },
      },
    },
  ],
}

Original issue reported on code.google.com by yukawa@chromium.org on 2 Dec 2013 at 4:39

@GoogleCodeExporter
Copy link
Author

Fixed in r1802.

Original comment by yukawa@chromium.org on 3 Dec 2013 at 2:47

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant